aspect-build / aspect-build/rules_js

[BUG]: registry field without a scope should be respected

Open
#1,246 1 comment 0 reactions 0 assignees View on GitHub
enhancement good first issue help wanted
Dominant language
Starlark
Stars
378
Forks
183
Avg merge
1d 9h
Merged PRs (30d)
32

Description

### What is the current behavior?

npm_translate_lock (using bzlmod extensions) only appears to parse the registry field in the .npmrc file if it has a scope, ie
```
@myorg:registry=https://somewhere-else.com/myorg
```
but if the field `registry` is set without a scope, it is ignored.
```
registry=https://somewhere-else.com/myorg
```

### Describe the feature

The registry field without a a scope should be parsed and used for all node_modules packages, except when overridden by a scope specific registry

```
registry=https://somewhere-else.com/myorg
```

Contributor guide

Open the contributing guide

Research direction

Start by locating the npm_translate_lock implementation and the .npmrc parsing path used by its bzlmod extension. Trace how scoped registry entries are handled, then verify that an unscoped registry applies to packages without a scope while scoped entries still override it. Done means the reported configuration is respected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.