aspect-build / aspect-build/rules_js
[Bug]: dependency on root //:node_modules breaks transitive deps
- Dominant language
- Starlark
- Stars
- 378
- Forks
- 183
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 32
Description
### What happened?
See https://github.com/macourteau/aspect-tsproject-imports/tree/f008b8da3f4a5ad0e51a11da150f9171e58bf072
Run `bazel run //demo/web/apps/my-web-app`. The transitive deps of `express` are not available even though the full root `node_modules` is present in the runfiles. Removing [this extra dep](https://github.com/macourteau/aspect-tsproject-imports/blob/f008b8da3f4a5ad0e51a11da150f9171e58bf072/demo/web/apps/my-web-app/BUILD.bazel#L29) fixes it?
### Version
bazel: 6.3.1
rules_js: 1.31.0
rules_ts: 1.4.5
Contributor guide
Research direction
Start with demo/web/apps/my-web-app/BUILD.bazel and reproduce the issue using `bazel run //demo/web/apps/my-web-app` at the referenced commit. Compare the runfiles and transitive dependencies of `express` with and without the extra dependency on the root `//:node_modules`; done means the transitive dependencies are available in the failing configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- express, node.js
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100