aspect-build / aspect-build/rules_js

Better error messaging when using execpath and other make expansions

Open
#118 0 comments 3 reactions 0 assignees View on GitHub
can close? enhancement
Dominant language
Starlark
Stars
378
Forks
183
Avg merge
1d 9h
Merged PRs (30d)
32

Description

https://github.com/aspect-build/rules_js/pull/108 is an example of user error which is understandable, since rules_js sets the working directory differently from typical Bazel actions. We could:
- detect use of `$(execpath)` etc. without `../` and warn ahead-of-time
- same but only print after the action fails?
- provide different expansion helpers?
- modify behavior of them?

Contributor guide

Open the contributing guide

Research direction

Start with the user-error example in pull request 108 and examine how rules_js handles Bazel make expansions such as $(execpath). The issue presents several unresolved approaches, so done requires choosing and implementing one clear warning, expansion-helper, or behavior change.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.