aspect-build / aspect-build/rules_esbuild

Feature request: expose launcher_args in esbuild rule

Open
#81 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Starlark
Stars
35
Forks
45
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Currently there's no way to pass args directly to the ESBuild executable. I'd like to use the "log-override" arg (https://esbuild.github.io/api/#log-override), but I don't think there's any way to use this currently. Am I correct?

I think the way to do this would be to allow the user to pass through args into `launcher_args`:
https://github.com/aspect-build/rules_esbuild/blob/main/esbuild/private/esbuild.bzl#L265

Contributor guide

Open the contributing guide

Research direction

Start in esbuild/private/esbuild.bzl around line 265, where launcher_args is handled. Trace how the esbuild rule constructs the executable invocation and determine how user-provided arguments should reach it. Done means the rule exposes launcher_args so callers can pass options such as log-override directly to ESBuild.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.