aspect-build / aspect-build/rules_esbuild

[Bug]: bazel_sandbox_plugin is very slow

Open
#190 1 comment 0 reactions 0 assignees View on GitHub
bug need: investigation performance
Dominant language
Starlark
Stars
35
Forks
45
Avg merge
1d 1h
Merged PRs (30d)
1

Description

### What happened?

https://github.com/aspect-build/rules_esbuild/pull/160 added a JavaScript plugin.
Users report on Slack that this new feature in 0.18.0 increases bundling times by an unacceptable amount.

Maybe it can simply be optimized.
Or it could use the esbuild Go API instead if someone has the time to evaluate that and re-write it.

Setting https://github.com/aspect-build/rules_esbuild/blob/main/docs/esbuild.md#esbuild_bundle-bazel_sandbox_plugin to `False` is the workaround, though it reverts to earlier behavior of non-hermetic esbuild sometimes not picking up changes.

### Version

0.18.0

### How to reproduce

_No response_

### Any other information?

_No response_

Contributor guide

Open the contributing guide

Research direction

Review PR 160 and the esbuild_bundle.bazel_sandbox_plugin documentation entry first. Establish a reproducible bundling-time comparison, then evaluate optimizing the JavaScript plugin versus using the esbuild Go API; done means performance improves without losing the hermetic behavior described by the False workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, javascript
Domain
build-system
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.