aspect-build / aspect-build/aspect-cli

[FR]: Make it possible to do pathces for archives

Open
#934 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Starlark
Stars
165
Forks
45
Avg merge
1d 47m
Merged PRs (30d)
35

Description

### What is the current behavior?

Currently when you define a dependency in MODULE.aspect there is no way to apply patches to it.
```
axl_archive_dep(
name = "impacted",
urls = ["https://github.com/aspect-extensions/impacted/archive/b3f503fe6c6d8ac21ed061cc6b078b1886228b35.tar.gz"],
integrity = "sha256-pUp+0FZ/b+5KqCYFwZ1itxlOrSrA5lSDvdGpjnMypbQ=",
strip_prefix = "impacted-b3f503fe6c6d8ac21ed061cc6b078b1886228b35",
dev = True,
auto_use_tasks = True,
)

# unable to patch it
```

### Describe the feature

Bazel has something called archive_override that has the defination `None archive_override(module_name, urls, integrity='', strip_prefix='', patches=[], patch_cmds=[], patch_strip=0)`.
This is very useful when you want to use a library but only want to apply fixes that are not yet merged in, not planned, or similar. This otherwise does not seem possible to do without forking the archive, which might not be wanted. An example of this use case would be for aspect_rules_lint, where I want to patch some issues until they get merged or change some behaviour for our use case.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.