asmaloney / asmaloney/libE57Format
MinGW fails to compile due to warnings
- Dominant language
- C++
- Stars
- 191
- Forks
- 82
- Avg merge
- 7h 21m
- Merged PRs (30d)
- 1
Description
(From here: https://github.com/asmaloney/libE57Format/issues/245#issuecomment-1518088249)
I think his fix in CRCpp (which is what I used here) won't work for MinGW.
@UshnaGul - can you try changing the checks in CheckedFile.cpp from
```cpp
#if defined( WIN32 ) || defined( _WIN32 ) || defined( WINCE )
```
to
```cpp
#if defined( _MSC_VER )
```
That should turn off the pragmas MinGW doesn't understand. Not sure if it will throw other errors though.
Contributor guide
Research direction
Start in CheckedFile.cpp and inspect the platform checks around the compiler pragmas. Build the library with MinGW after making the requested compiler-specific adjustment; done means MinGW no longer fails on unsupported pragmas or related compilation errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100