ashrafee-dev / ashrafee-dev/scamshield-api
Make scripts/check.sh fail on test errors
Open
Beginner friendly
Nobody has claimed this yet.
good first issue
- Dominant language
- Python
- Stars
- 3
- Forks
- 10
- Avg merge
- 14h 44m
- Merged PRs (30d)
- 9
Description
Problem
scripts/check.sh does not enable fail-fast behavior. If tests fail but Pylint succeeds, the script can finish successfully and hide the failed test run.
Acceptance criteria
- Ensure a failed test or lint command produces a non-zero script exit status.
- Preserve the current test-then-lint order.
- Add a small shell-level verification or document how the behavior was checked.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with scripts/check.sh and inspect the existing test-then-lint commands. Verify that a failing test or lint command produces a non-zero script status while preserving that order, then add the requested shell-level verification or document how it was checked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, shell
- Domain
- testing, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100