asdf-vm / asdf-vm/asdf-nodejs

Since nvm v0.40.0 .nvmrc may contain comments

Open
#397 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
989
Forks
162
PR merge metrics
No merged PRs in 30d

Description

Since nvm [v0.40.0](https://github.com/nvm-sh/nvm/releases/tag/v0.40.0) `.nvmrc` may contain comments.

[[New] allow .nvmrc files to support comments](https://github.com/nvm-sh/nvm/commit/29dce5edfd0976f9a1728c5746715c24061fd404)

---

.nvmrc
```
# comment
20.16.0
```

This will not work anymore:

https://github.com/asdf-vm/asdf-nodejs/blob/c36e6f065d31437786e587de50f32c85b4972188/bin/parse-legacy-file#L8

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.