asdf-vm / asdf-vm/asdf-nodejs

Resolving LTS version only outputs major number

Open
#369 5 comments 21 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
989
Forks
162
PR merge metrics
No merged PRs in 30d

Description

## Describe the Bug

When trying to resolve latest lts node version, I'm getting the result I was not expecting. When I run `asdf nodejs resolve lts` it only outputs a current major number `18` instead of a full version specified: `18.18.0`. I get the same result when running `asdf nodejs resolve lts --latest-available`. Weirdly enough, running `asdf nodejs resolve lts --latest-installed` returns full version, so `18.18.0`, even though I have no node versions installed yet (I am assuming it is using latest available version as a fallback?).

That is also causing `asdf install nodejs lts` not working, because it cannot resolve version `18`.

## Steps to Reproduce

Run:
- `asdf install nodejs lts`
- or `asdf nodejs resolve lts`
- or `asdf nodejs resolve lts --latest-available`

## Expected Behaviour

Command `asdf nodejs resolve lts` should output full semantic version of latest available LTS Node version and `asdf install nodejs lts` should be able to install it. As of 2023-10-02 it should output `18.18.0`

## Actual Behaviour

Only major version number is printed

```
> asdf nodejs resolve lts
18
```

This causes `asdf install nodejs lts` to fail. It needs full version specified with `MAJOR.MINOR.PATCH`

```
> asdf install nodejs lts
Trying to update node-build... ok
node-build: definition not found: 18
```

## Environment

```
OS:
Darwin jabko-macbook 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:52 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8103 arm64

SHELL:
zsh 5.9 (x86_64-apple-darwin22.0)

BASH VERSION:
3.2.57(1)-release

ASDF VERSION:
v0.13.0

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/Users/jabko/.asdf
ASDF_DIR=/opt/homebrew/opt/asdf/libexec
ASDF_CONFIG_FILE=/Users/jabko/.asdfrc

ASDF INSTALLED PLUGINS:
golang https://github.com/asdf-community/asdf-golang.git master e7e8171
hugo https://github.com/NeoHsu/asdf-hugo.git master 125ce37
nodejs https://github.com/asdf-vm/asdf-nodejs.git master 9275f49
```

## asdf plugins affected (if relevant)

nodejs

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.