asdf-vm / asdf-vm/asdf-nodejs

install script assumes path of asdf

Open
#361 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Shell
Stars
989
Forks
162
PR merge metrics
No merged PRs in 30d

Description

In plugins/nodejs/bin/install, the invocation of `asdf reshim` assumes that it is findable on the PATH, which may not always be the case.

`asdf reshim "$(plugin_name)" "$ASDF_INSTALL_VERSION"`

I was able to work around it by modifying ../lib/utils.sh to export ASDF_DIR:

```export ASDF_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")/../../.." && pwd)```

and prepending the path to `asdf` in install:

```$ASDF_DIR/bin/asdf reshim "$(plugin_name)" "$ASDF_INSTALL_VERSION"```

I will submit a patch for this if you like.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.