asciidisco / asciidisco/plugin.video.netflix
Cookie expired time wrong compared
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 213
- PR merge metrics
- No merged PRs in 30d
Description
*I'm submitting a ...*
- [x] bug report
- [ ] feature request
- [ ] support request
### Prerequisites
* [x] Are you running the latest version?
### Description
In [NetflixSession.py#L256](https://github.com/asciidisco/plugin.video.netflix/blob/master/resources/lib/NetflixSession.py#L256) the comparison of the expire time selects the oldest cookie. I think it should be `expires < exp` (resp. `exp > expires`). Once the first cookie will expire, the speed will drop for all `Netflix.router()` calls.
I also looked into the cookie-db and found a cookie with `expires=3697214258` (year 2087, it will never expire); maybe this will create problems, I'm not sure.
BR Joe
Contributor guide
Research direction
Read resources/lib/NetflixSession.py at line 256 and trace how cookie expiration is compared before Netflix.router() calls. Verify the intended selection using the noted far-future cookie value, then confirm the corrected behavior with the relevant session flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100