asciidisco / asciidisco/plugin.video.netflix

'Library.get_previewimage' uses 'nx_common.default_fanart'

Open
#492 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.2k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

*I'm submitting a ...*
- [x] bug report
- [ ] feature request
- [ ] support request

## General infomration

### Prerequisites

* [x] Are you running the latest version?

### Description
The function `lib.resources.Library.get_previewimage` uses the variable `default_fanart`; this exists in `KodiHelper` but not in `NetflixCommon`. A possible solution could be to write `self.nx_common.get_addon_info('fanart')` or `self.kodi_helper.default_fanart` instead (I tested the first).

### Steps to Reproduce
Open **Exported** with existing entries.

Contributor guide

Open the contributing guide

Research direction

Start at lib.resources.Library.get_previewimage and inspect how it obtains the default fanart value from NetflixCommon and KodiHelper. Reproduce the issue by opening Exported with existing entries, then verify that preview images load without the missing-variable error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.