asbjornenge / asbjornenge/thinking-in-react
Step 2: Part 3 - test does not account for header row
- Dominant language
- JavaScript
- Stars
- 179
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
The tests for ProductRows failed when we added a header row based on the UI-template given with "Name" and "Price" in the top.
We thought this was a ProductRow in the top, so we initialized the result array with a ProductRow.
``` javascript
var result = [
ProductRow({name:"Name", price:"Price"})
];
```
This is due to the test expecting the same amount of ProductRows as there is products.
Maybe add a Header row as well?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by running the ProductRows tests and reading the result initialization shown in the issue. Check how the UI template's Name/Price header is represented and how the tests count rows; done means the tests cover the header without treating it as a product row.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100