arunghosh / arunghosh/django-values

BooleanValue does not change from True to False

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
auto-migrated
Dominant language
Python
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

```
What steps will reproduce the problem?
1. Create a BooleanValue setting
2. In the admin check the value and save
3. Uncheck the value and save

What is the expected output? What do you see instead?
I expect the checkbox to be unchecked, but it remains checked. Also there
is no message that any change has occured

What version of the product are you using? On what operating system?
the latest checkout from svn. ubuntu 9.10

Please provide any additional information below.
I looked at the source: views.py line 34 and noticed the line:
if value and current_value != setting.to_python(value):
...
however, if the checkbox was just unchecked (changed state from checked to
unchecked), value = False, current_value = True, setting.to_python(value) =
False
so we have if False != False which gives False and so the rest of the
processing is skipped for this value, hence the value does not change ...
```

Original issue reported on code.google.com by `bayokra...@gmail.com` on 27 Feb 2010 at 8:11

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at views.py line 34 and reproduce the admin workflow described: save a checked BooleanValue, then uncheck and save it. Done means the stored value changes to False and the normal change notification appears instead of the update being skipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.