artofscience / artofscience/SAOR
Refactor `criterion` class
Open
enhancement
help wanted
paper
urgent for subtle reasons
- Dominant language
- Python
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
After talking to @artofscience, we agreed upon making the following changes to the convergence criteria class:
1. Rename `converged` object to `criterion` tp make it self-explanatory.
2. Add a `criterion.value` attribute in order to access its value without recalculating it.
3. Return an array of values if multiple criteria are considered at the same time.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.