arthurnn / arthurnn/twirp-ruby

Task: Integration test for the protoc-gen bin

Open
#95 0 comments 0 reactions 0 assignees View on GitHub
good first issue help wanted
Dominant language
Ruby
Stars
163
Forks
61
PR merge metrics
No merged PRs in 30d

Description

Do we test the protocol-gen-twirp_ruby ?
1. I see the go bin has a main_test.go file, but I don't see we call it during our action CI build
Note: `cd protoc-gen-twirp_ruby && go test ./...` will execute the test
2. We could have a integration test, where from a .proto file we generate the stubs, and asserts against that, to prevent major breaking changes.
3. Idea: bring some of the example app as part of our test suite.

1 is a easy win, 2 and 3 are more like ideas, but the overall goal here is to have tests that trigger the protoc ruby bin.

Contributor guide

Open the contributing guide

Research direction

Start in protoc-gen-twirp_ruby and inspect main_test.go, then run `cd protoc-gen-twirp_ruby && go test ./...` to check whether the existing tests run in CI. Review the action CI configuration and the .proto generation flow; done means the protoc Ruby binary is exercised by automated tests, with generated stubs or an example app covered if that scope is chosen.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, ruby
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.