art049 / art049/odmantic

`database` argument for `Engine`s defaulted to `"test"` is unexpected

Open
#348 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.2k
Forks
97
PR merge metrics
No merged PRs in 30d

Description

1. Can `client.get_default_database` eliminate `database` argument?
2. Or remove default to avoid mis-configuration.

https://github.com/art049/odmantic/blob/739a683398087ea5f93f5f6bd9080e9b3110e7a2/odmantic/engine.py#L166

Contributor guide

Open the contributing guide

Research direction

Start in odmantic/engine.py around line 166 and inspect how Engine passes the database argument to get_default_database. The issue is done when the unexpected "test" default is resolved without allowing this misconfiguration, with the chosen behavior verified against the existing Engine behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
mongodb, python
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.