arqex / arqex/react-json

Remove href="#" references to be compatible with frontend routers (i.e react-router)

Open
#11 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
97
Forks
38
PR merge metrics
No merged PRs in 30d

Description

Having `href="#"` in components breakes react-router route handling.
Also it has not real use but having proper cursor over links.

Related: https://github.com/alvarium/react-json/pull/1, https://github.com/alvarium/react-json/commit/382dd348836c68c451a0aa47462cc8c5c699f5bd

Maybe it can be removed in components. I can make a PR if needed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.