arqex / arqex/react-datetime

In Controlled mode, dialog closes early just after one click of up or down arrow in time picking

Open
#208 5 comments 1 reaction 0 assignees View on GitHub
feature request
Dominant language
JavaScript
Stars
2k
Forks
858
PR merge metrics
No merged PRs in 30d

Description

We are using this component as controlled component because we want to use Semantic UI as Input box and open this component as controlled component.

In this mode, date picking works as expected. Clicking on date closes the dialog. Clicking on Month or Year doesn't close.

However, going to pick time, moment I click single up or down arrow of hour, minute or second, it fires the onChange event, effectively closing the dialog. Is it possible to not fire onChagne event till they completely exit out of the time mode? or Add Ok button to time mode?

Or is it possible to add Ok button to overall dialog so user can make explicit indication that they done with selection?

Contributor guide

Open the contributing guide

Research direction

Reproduce the controlled-mode flow described in the issue, focusing on the time picker’s hour, minute, and second arrow controls and the onChange path. Trace how a single arrow click closes the dialog, then verify that the chosen completion behavior prevents premature closing while preserving the existing date, month, and year behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.