armory3d / armory3d/armorpaint

Brush nodes issues

Open
#789 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
C
Stars
5k
Forks
553
Avg merge
3d 11h
Merged PRs (30d)
6

Description

The export of image texture node assets works very well, it seems a positive development in brush export.

There are a couple of details that seem to need revision...

1 - when importing a previously exported brush, in the brushes tab the imported brush does not show a preview of the mask used by the brush in the image texture node. The screenshot shows that I have imported 2 brushes: apb_ink_124 and apb_ink_125. Neither of them shows the brush mask in the brushes tab preview, although the brush works correctly it is not possible to visualize it for easy identification.

2 - When a brush is imported it does not check that the brush mask is not present in the assets, and if it was already present it duplicates it as seen in the imported textures tab. The import of the brush apb_ink_125 generated a duplicate of apb_ink_125.png that for some reason or error was already imported previously.

3 - When resting the mouse over the imported brush for a few seconds, a preview of the brush application is generated, but in this case, I do not know if it is due to the lack of the initial preview of the brush tip or mask, or that it is a brush with completely random values, what you see is a completely black image. Possibly it is a scaling of the brush tip depending on the totality of the texture or uvmap on which it is going to paint? If this is the case, perhaps it would be more convenient to amplify the brush mask used in the image texture node. You can't see very well what the preview shows. Maybe because of its scaling.

They are secondary details, the brush works fine when painting.

ArmorPaint.org - v0.8 (2021-01-28) - 229adac
Fedora 32 - Linux - OpenGL

![Screenshot_20210128_162719](https://user-images.githubusercontent.com/77791463/106190178-0dce4300-6188-11eb-8d9d-7a1a259ab608.png)
![Screenshot_20210128_162824](https://user-images.githubusercontent.com/77791463/106190208-16bf1480-6188-11eb-990f-1cefb14905ed.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the import of apb_ink_124 and apb_ink_125, then inspect the brush import path, Brushes tab preview, and imported textures tab. Check the behavior for an existing mask, the missing brush-mask preview, and the black hover preview; done means imported brushes preview correctly without duplicate mask assets.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.