armbian / armbian/build

Fix brace expansion in AIC8800 bluetooth service check across board configs

Open
#8,548 2 comments 0 reactions 1 assignee Claimed by @leggewie View on GitHub
Dominant language
Shell
Stars
5.4k
Forks
3.1k
Avg merge
1d 9h
Merged PRs (30d)
204

Description

## Problem

The `post_family_tweaks__enable_aic8800_bluetooth_service()` function in several board configuration files uses brace expansion with `test -f`, which causes the test command to fail because it receives multiple arguments instead of one.

## Affected Files

- `config/boards/kickpik2b.csc`
- `config/boards/radxa-cubie-a5e.csc`
- `config/boards/radxa-zero3.csc`

## Current Problematic Code

```bash
if chroot_sdcard test -f {/lib/,/usr/lib/,/etc/}systemd/system/aic-bluetooth.service; then
```

## Solution

Replace with explicit OR checks:

```bash
if chroot_sdcard test -f /lib/systemd/system/aic-bluetooth.service || \
chroot_sdcard test -f /usr/lib/systemd/system/aic-bluetooth.service || \
chroot_sdcard test -f /etc/systemd/system/aic-bluetooth.service; then
```

## Context

This issue was identified during review of PR #8511 but deferred to a separate PR to keep changes focused.

**References:**
- PR: https://github.com/armbian/build/pull/8511
- Comment: https://github.com/armbian/build/pull/8511#discussion_r2301112753

**Requested by:** @leggewie

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.