`USERPATCHES_PATH` customization and inconsistency across the framework
- Dominant language
- Shell
- Stars
- 5.4k
- Forks
- 3.1k
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 204
Description
By chance I was thinking about organizing various custom configurations I thought about having multiple directories for userpatches and define one of these at runtime.
From what I've seen the path seems to be set here: https://github.com/armbian/build/blob/134ae2964685f685fff8c19c2ef3fa6c29819f08/lib/functions/cli/entrypoint.sh#L87
and from there going forward the path should be stored in `$USERPATCHES_PATH` variable, right?
However search simply for `userpatches` reveals that on several occasions the path seems to be hard-coded (list incomplete):
https://github.com/armbian/build/blob/134ae2964685f685fff8c19c2ef3fa6c29819f08/lib/functions/cli/utils-cli.sh#L147
https://github.com/armbian/build/blob/134ae2964685f685fff8c19c2ef3fa6c29819f08/extensions/gen-sample-extension-docs.sh#L13
https://github.com/armbian/build/blob/134ae2964685f685fff8c19c2ef3fa6c29819f08/lib/functions/host/docker.sh#L572
So the question is am I wrong here for some reason? Is this intended? Should the path be stored in a variable everywhere? Should the patch possible be customizable? Like `./compile.sh BOARD=asdf USERPATCHES_PATH=asdf MyConfigInAsdf`
Contributor guide
Assessment
This issue has not been assessed yet.