armbian / armbian/build

OFFLINE_WORK is fragile and untested

Open
#4,315 3 comments 0 reactions 0 assignees View on GitHub
Bugfix Discussion Help needed
Dominant language
Shell
Stars
5.4k
Forks
3.1k
Avg merge
1d 9h
Merged PRs (30d)
204

Description

e.g. on a NanoPi R4S image build, we attempt to install ethtool off the internet. That obviously doesn't work.

While I can fix that one specific issue with ethtool's package, I think fundamentally we would have to have some CI/CD testing of `OFFLINE_WORK`.

Open question: should we remove this flag completely for now, add a warning, or wait until it's fixed?

Contributor guide

Open the contributing guide

Research direction

Start by tracing the OFFLINE_WORK handling in the image-build scripts and the package-install path that attempts to fetch ethtool. Review how CI/CD could exercise offline builds; done means the policy for OFFLINE_WORK is resolved and offline builds no longer attempt internet-dependent installation.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.