Critical: ArkavoMessageRouter initialization incomplete
- Dominant language
- Swift
- Stars
- 0
- Forks
- 0
- Avg merge
- 1h 41m
- Merged PRs (30d)
- 1
Description
## Problem
The ArkavoMessageRouter initialization is commented out with a TODO in `ArkavoCreatorApp.swift`, which means core messaging functionality may not work properly.
## Impact
- **Severity:** Critical
- **Category:** Bug
- Core messaging and workflow features may be broken
- Message routing between components won't function
- Affects the entire Workflow view functionality
## Location
`ArkavoCreator/ArkavoCreator/ArkavoCreatorApp.swift:39-44`
## Current Code
```swift
init() {
arkavoClient = ArkavoClient(
authURL: URL(string: https://webauthn.arkavo.net)!,
websocketURL: URL(string: wss://100.arkavo.net)!,
relyingPartyID: webauthn.arkavo.net,
curve: .p256,
)
ViewModelFactory.shared.serviceLocator.register(arkavoClient)
// TODO: Initialize router
// let router = ArkavoMessageRouter(
// client: client,
// persistenceController: PersistenceController.shared
// )
// _messageRouter = StateObject(wrappedValue: router)
// ViewModelFactory.shared.serviceLocator.register(router)
}
```
## Required Actions
1. Uncomment and complete the ArkavoMessageRouter initialization
2. Verify PersistenceController is available in ArkavoCreator
3. Ensure proper dependency injection for the router
4. Test message routing functionality end-to-end
5. Update ViewModelFactory to properly resolve the router
## Dependencies to Check
- Does ArkavoCreator have access to `ArkavoMessageRouter`?
- Is `PersistenceController` available in this context?
- Are all required imports present?
## Testing Requirements
- [ ] Verify router initializes without errors
- [ ] Test message sending through workflow
- [ ] Verify message routing to correct handlers
- [ ] Check WebSocket message processing
- [ ] Validate persistence integration
## Acceptance Criteria
- [ ] Router initialization code uncommented and working
- [ ] All dependencies properly resolved
- [ ] Message routing tested and functional
- [ ] No compilation errors
- [ ] Integration tests pass
## Priority
Must be fixed before launch - core functionality broken
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in ArkavoCreator/ArkavoCreator/ArkavoCreatorApp.swift:39-44 and trace ArkavoMessageRouter, PersistenceController, and ViewModelFactory availability and registration. Verify the router initializes without compilation errors, then test workflow message sending, handler routing, WebSocket processing, and persistence integration until the listed acceptance criteria pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100