aristanetworks / aristanetworks/goeapi

Non-configurable connection timeout (60s)

Open
#61 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
60
Forks
36
PR merge metrics
No merged PRs in 30d

Description

The connection timeout is 60 seconds, if the remote end is not properly responding. The current unit test that does a tmeout test is not doing that test -- instead it is doing a test connecting to 1.1.1.2:80 (which is a web server that responds, if the machine you run tests on has internet access), so it's testing against a webserver that gives an error response instead. I'll submit a PR for a test that actually tests a timeout and exposes this 60 second timeout.

It would be ideal if timeouts could be used with Connect().

Contributor guide

Open the contributing guide

Research direction

Start by locating Connect() and the current timeout unit test that connects to 1.1.1.2:80. Check how the 60-second timeout is applied and how a caller could configure it through Connect(). Done means the test exercises a real timeout without relying on an internet response and callers can use a configured connection timeout.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.