arik-so / arik-so/ldk-parser

Consider hiding label for methods with only one argument

Open
#26 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Swift
Stars
0
Forks
2
PR merge metrics
No merged PRs in 30d

Description

instead of `Invoice.fromStr(s: "string goes here")` consider changing the method signature to

`class func fromStr(_ s: String)`

so the call becomes `Invoice.fromStr("string goes here")` instead. Thoughts?

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the Invoice.fromStr definition and its callers, then read how the current argument label is used. Decide whether the unlabeled signature is appropriate for this API, update the affected call sites and tests if the change is accepted, and verify the project still passes its test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.