argyleink / argyleink/open-props
Inconsistency in Naming of Custom Media Queries for Size Ranges
- Dominant language
- HTML
- Stars
- 5.5k
- Forks
- 216
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
I was reviewing the custom media queries defined in the CSS, and I noticed an inconsistency in the naming convention used for the size ranges. Specifically, the naming for the --xxs-n-above and --xxs-n-below queries seems to be misrepresenting the actual size ranges they cover.
Here's the relevant code snippet:
```css
@custom-media --xxs-only (0px <= width <= 240px);
@custom-media --xxs-n-above (width >= 240px);
@custom-media --xxs-n-below (width < 240px);
```
The --xxs-n-above query is defined as (width >= 240px), which technically covers the range of "XS and Above" rather than "XXS and Above" as the name suggests. Similarly, the --xxs-n-below query covers the range of "XXS and Below", but the name might suggest it excludes the XXS range.
I would like to propose a revision in the naming convention to accurately represent the size ranges each query covers. For instance, renaming --xxs-n-above to --xs-n-above and adjusting other similar query names accordingly would provide a clearer understanding of the size ranges they represent.
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate the CSS file defining the custom media queries and compare the --xxs, --xs, and related size-range names with their width expressions. Update the inconsistent names so each label matches its range, then verify the complete custom-media set is consistent with the stated convention.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100