argyleink / argyleink/open-props
Shadows can be too dark
- Dominant language
- HTML
- Stars
- 5.5k
- Forks
- 216
- PR merge metrics
- No merged PRs in 30d
Description
If someone is using the shadow props and NOT building a dark theme while the user is in a prefers dark mode, the shadows adapt to the preference and are overly dark in the light document.
I think we'd need a media query for `color-scheme` in order to properly handle it. then the shadows could pivot on that instead of the media query.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the shadow props and the media-query definitions that make them respond to dark-mode preferences. Reproduce the issue in a light document with prefers dark mode enabled, then verify that the shadows no longer become overly dark when no dark theme is being built.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100