argumentcomputer / argumentcomputer/ci-workflows

Lint job does not build tests for the Wasm platform (and should)

Open
#10 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
0
Forks
3
Avg merge
59m
Merged PRs (30d)
2

Description

https://github.com/lurk-lab/ci-workflows/blob/0fbbf18385feb7422756dcf7c7a002d3a732bd5d/.github/workflows/lints.yml#L17-L19

This should build tests (and ideally examples / benches as well) to ensure full compatibility.

If we want to *run* tests on wasm, we'd have to install a wasm runtime (and indicate it in the .cargo/config of the runner:
```toml
[target.wasm32-unknown-unknown]
runner = 'my-favorite-runner'
```
but let's at least check the tests *compile*

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with .github/workflows/lints.yml at lines 17-19 and inspect how the lint job builds the Wasm target. Update the workflow so tests are compiled for wasm32-unknown-unknown, and consider the issue's requested examples and benches if the existing job structure supports them. Done means the workflow checks compilation without requiring a Wasm runtime.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, wasm
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.