argotorg / argotorg/solidity

Verify and potentially increase test coverage for inheritance and function calls.

Open
#8,437 3 comments 0 reactions 0 assignees View on GitHub
low impact medium effort must have eventually testing :hammer:
Dominant language
C++
Stars
25.7k
Forks
6.2k
Avg merge
2d 19h
Merged PRs (30d)
29

Description

We didn't have a single test case that failed on https://github.com/ethereum/solidity/issues/8434 - I added two measly test cases in https://github.com/ethereum/solidity/pull/8436, but that's probably far from enough and I'm afraid this could only be the tip of the iceberg wrt test coverage in this area, so we should check this and potentially add a lot more tests for function calls in general and especially in the presence of various inheritance scenarios.

Contributor guide

Open the contributing guide

Research direction

Review issue 8434 and the two test cases added in pull request 8436 first. Search the repository's existing inheritance and function-call tests, then identify missing combinations and add coverage for the relevant scenarios; done means the regression is covered and broader inheritance/function-call cases are tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, solidity
Domain
compilers, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.