argotorg / argotorg/solidity

Extend ethdebug schema validator test cases

Open
#16,506 3 comments 0 reactions 1 assignee Claimed by @nikola-matic View on GitHub
ethdebug low effort medium impact must have testing :hammer:
Dominant language
C++
Stars
25.7k
Forks
6.2k
Avg merge
2d 19h
Merged PRs (30d)
29

Description

## Abstract

We have tests in place that will check the `solc` output with respect to their conformity to the ethdebug schema: [`ethdebugSchemaTests/`](https://github.com/argotorg/solidity/tree/v0.8.34/test/ethdebugSchemaTests).

Right now we merely have two smoketests in there. We should run such tests on some subset (or all) of the tests in the repository like for AST or evmasm import.

## Motivation

The schema is directly pulled from the [ethdebug source](https://github.com/ethdebug/format.git) to ensure
that we

1. adapt to changes in the schema quickly and
2. do not produce invalid output (validity with respect to schema).

## Specification

It should be enough to `rglob` for test files ahead of test time and add them to the args in the test definition:

https://github.com/argotorg/solidity/blob/63131344df6e0038729fa9da4f04c1e88a2ab087/test/ethdebugSchemaTests/test_ethdebug_schema_conformity.py#L17-L18

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.