Enforce lack of gas expectations for configurations that a test skips
- Dominant language
- C++
- Stars
- 25.7k
- Forks
- 6.2k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 21
Description
As noted in https://github.com/argotorg/solidity/pull/16369#discussion_r2781985995, some tests still had stale legacy gas expectations after #16348, despite only running via Yul.
We should fix this by validating that tests do not have gas expectations for pipelines that are not enabled. Specifically:
- Tests with `// compileViaYul: true` (Yul-only) should not have `// gas legacy:` or `// gas legacyOptimized:` expectations
- Tests with `// compileViaYul: false` (legacy-only) should not have `// gas irOptimized:` expectations
Contributor guide
Research direction
No file or test path is named. Locate the test harness that reads compileViaYul and gas expectations, then run its relevant tests; done means Yul-only tests reject legacy gas expectations, legacy-only tests reject irOptimized expectations, and valid configurations continue to pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, solidity
- Domain
- compilers, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100