argotorg / argotorg/solidity

Disallow `--libraries <file>:<library>:<address>` format

Open
#16,166 0 comments 0 reactions 0 assignees View on GitHub
breaking change :warning: low effort low impact should have
Dominant language
C++
Stars
25.7k
Forks
6.2k
Avg merge
1d 11h
Merged PRs (30d)
21

Description

## Abstract
The `--libraries` option accepts both `::

` and `:=
` as argument. From now on only accept the latter.

## Motivation
We originally accepted only the format with `:`. The one with `=` was introduced in #10707 to make the syntax less ambiguous visually (though note that it's not ambiguous to parse since neither the library name, nor the address can contain `:`). Together with the removal of support for unqualified library names (#12145) this will make command-line option parsing simpler and more regular.

## Specification
- Report an error when the value does not contain the `=` sign.
- Update docs to remove mentions of the old format.

## Backwards Compatibility
This is a breaking change to command-line interface.

Contributor guide

Open the contributing guide

Research direction

Start at the command-line parsing entry point for the --libraries option and search the documentation for both accepted argument formats. Verify that values without '=' produce an error, that the '=' form remains accepted, and that documentation no longer mentions the colon form.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli, documentation
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.