Introduce an exception type for the AST Json importer and use as replacements for `solAsserts`
- Dominant language
- C++
- Stars
- 25.7k
- Forks
- 6.2k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 29
Description
Suggested here: https://github.com/ethereum/solidity/pull/15463#discussion_r1946701186
The AST Json Importer has many instances of `solAssert` being used for validation/error messaging. As suggested in the linked comment, it would be better to have a specific exception for those cases.
Also, note that currently exceptions are not caught in standard JSON mode and that needs to be adjusted as well.
Contributor guide
Research direction
Start with the AST Json Importer and the linked pull-request discussion describing the proposed exception. Trace the existing solAssert validation paths and standard JSON mode handling. Done means importer-specific validation errors use the new exception type and are correctly caught in standard JSON mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, solidity
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100