argotorg / argotorg/solidity

Use the IR compilation pipeline in all CLI tests

Open
#14,547 1 comment 0 reactions 0 assignees View on GitHub
low effort low impact must have eventually testing :hammer:
Dominant language
C++
Stars
25.7k
Forks
6.2k
Avg merge
2d 19h
Merged PRs (30d)
29

Description

Currently we still have some tests that use the legacy pipeline, most of them in the `cmdlineTests` suite. We should switch them over to `--via-ir`.

Examples:
- [`~compilation_tests`](https://github.com/ethereum/solidity/blob/develop/test/cmdlineTests/~compilation_tests/test.sh)
- [`~documentation_examples`](https://github.com/ethereum/solidity/blob/develop/test/cmdlineTests/~documentation_examples/test.sh)
- [`docs_version_pragma_check.sh`](https://github.com/ethereum/solidity/blob/develop/scripts/docs_version_pragma_check.sh)

Many of them use the `compileFull` helper, so making it run via IR by default would be a good idea.

Find them all and convert them.

Contributor guide

Open the contributing guide

Research direction

Start with test/cmdlineTests/~compilation_tests/test.sh, test/cmdlineTests/~documentation_examples/test.sh, and scripts/docs_version_pragma_check.sh; inspect the compileFull helper and existing --via-ir usage. Run the affected CLI tests before and after converting legacy-pipeline cases, then search the cmdlineTests suite for remaining cases. Done means all identified CLI tests use the IR pipeline without regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, shell, solidity
Domain
cli, compilers, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.