argotorg / argotorg/solidity

Check Randomness in Phaser Tests

Open
#12,488 0 comments 0 reactions 0 assignees View on GitHub
bug :bug: low effort low impact should have testing :hammer:
Dominant language
C++
Stars
25.7k
Forks
6.2k
Avg merge
1d 11h
Merged PRs (30d)
21

Description

The phaser tests use partly fixed partly time-based seeds, so the choice of tests will affect behaviour.
@cameel wanted to look into them on a per-case basis.

I'd suggest to give all of them a fixed seed by default and add an soltest option with a nightly run that changes that behaviour to random seeds (and maybe higher sample sizes to avoid failures then, since runtime will be less of a concern).

Contributor guide

Open the contributing guide

Research direction

Start by locating the phaser tests and the soltest option handling. Trace how their seeds and sample sizes are selected, then determine how a nightly run could enable random seeds; done means fixed seeds by default with a separate random-seed mode for nightly testing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.