argotorg / argotorg/solidity

[isoltest] Allow empty input (even when expected) in TestFileParser

Open
#10,591 0 comments 0 reactions 0 assignees View on GitHub
bug :bug: good first issue candidate low impact medium difficulty testing :hammer:
Dominant language
C++
Stars
25.7k
Forks
6.2k
Avg merge
1d 11h
Merged PRs (30d)
21

Description

Actually the test parser doesn't allow empty input. This fails parsing:
```
// deposit(bytes,bytes,bytes,bytes32), 32 ether: -> FAILURE # Empty input #
```

With:
```
semanticTests/externalContracts/deposit_contract.sol: Exception during test: Throw location unknown (consider using BOOST_THROW_EXCEPTION)
Dynamic exception type: solidity::frontend::test::TestParserError
std::exception::what: Line 188: No argument provided.
[solidity::util::tag_comment*] = Line 188: No argument provided.
```

_Originally posted by @axic in https://github.com/ethereum/solidity/pull/10590#r542372647_

Contributor guide

Open the contributing guide

Research direction

Locate TestFileParser and reproduce the failure using semanticTests/externalContracts/deposit_contract.sol, focusing on the empty input in the shown comment. The work is done when this input parses without the Line 188 “No argument provided” error while existing parser behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, solidity
Domain
compilers, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.