argotorg / argotorg/solidity

Inconsistent library address validations between CLI and Standard JSON

Open
#10,299 19 comments 0 reactions 0 assignees View on GitHub
bug :bug: easy difficulty low effort low impact should have
Dominant language
C++
Stars
25.7k
Forks
6.2k
Avg merge
1d 11h
Merged PRs (30d)
21

Description

Checks applied to the value of `--library` option in CLI are not exactly the same as the ones for `libraries` in Standard JSON. For example only CLI checks address checksum. The validations should be reviewed and unified.

Contributor guide

Open the contributing guide

Research direction

Compare the validation entry points for the CLI `--library` option and the Standard JSON `libraries` field, beginning with the existing address and checksum checks in each path. Review related compiler tests, then unify the validations and confirm both interfaces accept and reject the same library addresses.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, solidity
Domain
cli, compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.