argotorg / argotorg/solc-js

Test that `downloadCurrentVersion.ts` actually downloads the latest version

Open
#632 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue testing :hammer:
Dominant language
TypeScript
Stars
1.5k
Forks
350
Avg merge
8m
Merged PRs (30d)
1

Description

We used to test that solcjs --version returns a version matching the one from package.json. I changed that in #626 because this is not really guaranteed - the returned version depends on the binary. So now we should also add a proper test that downloadCurrentVersion.ts actually does its job and downloads the right binary. It could be a JS test or an additional check in one of the jobs in CI.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read downloadCurrentVersion.ts and review the version-checking change in #626 first. Decide whether the new coverage belongs in a JavaScript test or a CI job, then verify that downloading the current version produces the binary corresponding to the expected latest version.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
ci-cd, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.