argotorg / argotorg/solc-js

Solidity <0.4.20 creates incorrect contracts output when are file paths with colon in them; could wrapper repair this?

Open
#557 2 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
TypeScript
Stars
1.5k
Forks
349
Avg merge
8m
Merged PRs (30d)
1

Description

Filing this issue based on discussion in #555. Currently[0] Truffle repairs this (see [this Truffle PR](https://github.com/trufflesuite/truffle/pull/4363) for more info), but over on #555 @cameel suggested that perhaps `solc/wrapper` should be reparing this. (And then the fix would apply to everyone, not just Truffle, and we could remove our code for repairing it.) So, filing this issue asking for that.

[0]Well, OK, as of when I write this the fix isn't released yet, but it is merged...

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading discussion #555 and the linked Truffle PR to understand how paths containing colons are repaired. Then locate the solc/wrapper handling for Solidity versions below 0.4.20 and verify that its output is corrected for those paths; the issue does not name a specific file or test.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity, typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.