argotorg / argotorg/hevm

Change in pretty printing breaks dapptools integration tests

Open
#243 5 comments 0 reactions 0 assignees View on GitHub
low-priority
Dominant language
Haskell
Stars
358
Forks
79
Avg merge
1d 1h
Merged PRs (30d)
6

Description

Specifically, [this test](
https://github.com/dapphub/dapptools/tree/f932a37f70b2bd33d24f4d412d7e4f2cec53d1e3/src/dapp-tests/integration/tests.sh#L631) breaks [like so](https://github.com/dapphub/dapptools/actions/runs/4271170230/jobs/7435449871#step:5:2023).

From OOB discussions with @xwvvvvwx, I think this has something to do with how hevm changed its pretty printing of contract names in some logs.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/dapp-tests/integration/tests.sh around line 631 and reproduce the linked dapptools integration failure. Compare the contract-name pretty printing in the affected logs with the expected output, then rerun that integration test and confirm the dapptools action passes with the corrected output.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
blockchain, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.