Support windows-style newlines in parser
- Dominant language
- Rust
- Stars
- 1.7k
- Forks
- 218
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 6
Description
### What is wrong?
The parser doesn't account for the possibility of a carriage return `\r` prior to a newline `\n`, and so it'll reject windows-style CRLF newlines.
### How can it be fixed
Probably just need to update the newline regex in `crates/parser/src/lexer/token.rs` to allow for an optional `\r` (but I may be forgetting something).
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in crates/parser/src/lexer/token.rs and inspect the newline-matching regex used by the lexer. Verify the parser's newline handling with Windows-style CRLF input, and consider the issue complete when such input is accepted without breaking existing newline handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100