argotorg / argotorg/fe

Make more unit tests run on wasm

Open
#466 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.7k
Forks
218
Avg merge
1d 7h
Merged PRs (30d)
6

Description

### What is wrong?

Only some of the tests run on wasm; specifically the parser tests, analyzer error tests, and yulgen tests (search for "wasm_bindgen_test"). The rest of the tests should be refactored to be wasm-friendly.

### How can it be fixed

Mostly this involves replacing the dynamic `fs` file reading with `include_str!` macro calls, which will probably require refactoring some tests that use `rstest` to use custom macros instead (see the `test_file` macro in tests/src/compile_errors.rs)

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the test suite for "wasm_bindgen_test" and compare the parser, analyzer error, and yulgen tests with the remaining tests. Start with the test_file macro in tests/src/compile_errors.rs and identify dynamic fs reads that need include_str! or custom macros instead of rstest. Done means the remaining unit tests are refactored to run on wasm.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, wasm
Domain
compilers, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.