argoproj / argoproj/notifications-engine

github integration is not supported for argo rollouts

Open
#86 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
334
Forks
217
PR merge metrics
No merged PRs in 30d

Description

I am getting index out of the range for accessing the second part of reporURL in [here](
https://github.com/argoproj/notifications-engine/blob/7b9b5d3281e1b52c17b04369de1cda8072d15072/pkg/services/github.go#L193)

I think repoURL is hard-coded to be [.app.spec.source.repoURL](https://github.com/argoproj/notifications-engine/blob/7b9b5d3281e1b52c17b04369de1cda8072d15072/pkg/services/github.go#L46) in here which is argocd only and doesnt support argo rollouts?

Contributor guide

No contributing guide indexed for this repository

Research direction

Read pkg/services/github.go at the linked lines 46 and 193, starting with how repoURL is taken from .app.spec.source.repoURL and then split. Trace how an Argo Rollouts repository URL reaches this code and define completion as GitHub integration handling it without an index-out-of-range error.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.