argoproj / argoproj/notifications-engine

Webhook service always uses GET method

Open
#83 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
334
Forks
217
PR merge metrics
No merged PRs in 30d

Description

Irrespective of configuration, the `webhook` service always uses the `GET` method.

I found the culprit here: https://github.com/argoproj/notifications-engine/blob/ac18ca10234c47eebfdb9797d5e995c00f86377c/pkg/services/webhook.go#L96

Contributor guide

No contributing guide indexed for this repository

Research direction

Read pkg/services/webhook.go around line 96 and trace how the configured method reaches the request. Confirm that webhook requests honor the configured HTTP method, then add or run relevant webhook-service coverage if the repository provides it.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.