argoproj / argoproj/notifications-engine
docs: Alertmanager reference shows use of {{.recipient}} this isn't possible
- Dominant language
- Go
- Stars
- 334
- Forks
- 217
- PR merge metrics
- No merged PRs in 30d
Description
The Alertmanager implementation does not extract and pass the recipient for a notification subscription.
Reference: https://github.com/argoproj/notifications-engine/blob/master/docs/services/alertmanager.md?plain=1#L149
The pagerduty service [Send()](https://github.com/argoproj/notifications-engine/blob/master/pkg/services/pagerdutyv2.go#L118) function uses dest.Recipient
In the alertmanager server [Send()](https://github.com/argoproj/notifications-engine/blob/master/docs/services/alertmanager.md?plain=1#L149) function there is not use of dest.Recipient (or in fact dest)
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with docs/services/alertmanager.md at the referenced line and compare its example with the Alertmanager Send implementation. Review pkg/services/pagerdutyv2.go and its Send function to understand the dest.Recipient usage contrast. Done when the Alertmanager reference no longer claims that an unavailable recipient value can be used.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100