argoproj / argoproj/notifications-engine

Check the number of readyReplicas before sending a notification

Open
#343 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
334
Forks
217
PR merge metrics
No merged PRs in 30d

Description

Hi all. I've been using ArgoCD Notifications for a while and there is a situation I would like to share with you. When enabled the "degraded" notifications, we started getting them on situations where I wasn't expecting it. For example: when there are non ready pods because the readiness probe temporary failed or when one k8s node is being replaced and the number of healthy replicas is below the desired number. I was thinking about adding a condition like "if the number of ready replicas is greater than zero and lesser than the desired number DO NOT trigger the notification". Is there a way I can check for the ready replicas?
Thanks in advance.

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue does not name files, tests, or an entry point. Start by locating how degraded notifications and their conditions are evaluated, then inspect which Kubernetes replica status fields are exposed to conditions. Done means defining and documenting a condition that distinguishes zero ready replicas from partially ready replicas, with coverage for the described pod and node-replacement cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.