argoproj / argoproj/notifications-engine

bug: old api-key version for New-Relic service

Open
#180 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
334
Forks
217
PR merge metrics
No merged PRs in 30d

Description

Now new-relic service uses old api key: https://github.com/argoproj/notifications-engine/blob/master/pkg/services/newrelic.go (line 153) `req.Header.Set("Api-Key", s.opts.ApiKey)`

According to documentation it should be `req.Header.Set("X-Api-Key", s.opts.ApiKey)` (https://docs.newrelic.com/docs/apis/rest-api-v2/get-started/introduction-new-relic-rest-api-v2/)

Now newrelic module doesn't create deployment markers. Same request with curl works (because of type of header).

Contributor guide

No contributing guide indexed for this repository

Research direction

Open pkg/services/newrelic.go around line 153 and compare the request header with the linked New Relic REST API documentation. Update the request so the New Relic module can create deployment markers, then verify that deployment-marker requests succeed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.