argoproj / argoproj/argo-workflows
No Spec Field returned from Archived ListWorkflows
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 17k
- Forks
- 3.7k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 138
Description
Pre-requisites
- I have double-checked my configuration
- I have tested with the
:latestimage tag (i.e.quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on:latest. If not, I have explained why, in detail, in my description below. - I have searched existing issues and could not find a match for this bug
- I'd like to contribute the fix myself (see contributing guide)
What happened? What did you expect to happen?
After upgrading to v3.6.5 from v3.5.5, we have noticed that when calling ListWorkflows on Workflows that have been persisted to our PostgresDB, it looks like spec.parameters (along with most of spec) no longer is returned. Looks like this happened during https://github.com/argoproj/argo-workflows/pull/13566 and you can see that spec field is not used at all in the SQL query in the codebase. Was this intended? Would love to open a PR to add this field back.
Version(s)
v3.6.5
Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflow that uses private images.
Any Workflow
Logs from the workflow controller
N/A
Logs from in your workflow's wait container
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ListWorkflows implementation and the SQL query changed in pull request #13566, then reproduce the archived-workflow response against PostgresDB using the v3.6.5 behavior. Compare the returned object with the persisted workflow, especially spec.parameters; done means archived ListWorkflows returns the expected spec fields without regressing the query.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, postgresql
- Domain
- api, backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100